Skip to content

fix: fix protobuf dependency#370

Merged
alaeddine-13 merged 2 commits into
mainfrom
fix-protobuf-dependency
May 26, 2022
Merged

fix: fix protobuf dependency#370
alaeddine-13 merged 2 commits into
mainfrom
fix-protobuf-dependency

Conversation

@alaeddine-13

Copy link
Copy Markdown
Member

recent release in protobuf causes the following problem:

TypeError: Descriptors cannot not be created directly.
If this call came from a _pb2.py file, your generated code is out of date and must be 
regenerated with protoc >= 3.19.0.
If you cannot immediately regenerate your protos, some other possible workarounds are:
 1. Downgrade the protobuf package to 3.20.x or lower.

As a quick fix, we fix the protobuf version to less than 4.21
The best solution would be to regenerate proto with protoc >= 3.19.0

@codecov

codecov Bot commented May 26, 2022

Copy link
Copy Markdown

Codecov Report

Merging #370 (426539e) into main (4213553) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   86.21%   86.20%   -0.01%     
==========================================
  Files         134      134              
  Lines        6324     6366      +42     
==========================================
+ Hits         5452     5488      +36     
- Misses        872      878       +6     
Flag Coverage Δ
docarray 86.20% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/weaviate/find.py 86.95% <0.00%> (-2.79%) ⬇️
docarray/array/mixins/find.py 87.35% <0.00%> (-1.26%) ⬇️
docarray/helper.py 76.66% <0.00%> (-0.84%) ⬇️
docarray/array/storage/qdrant/find.py 80.85% <0.00%> (ø)
docarray/array/storage/annlite/find.py 83.33% <0.00%> (ø)
docarray/array/storage/sqlite/backend.py 93.24% <0.00%> (ø)
docarray/array/storage/elastic/backend.py 94.39% <0.00%> (+0.05%) ⬆️
docarray/array/storage/qdrant/backend.py 95.91% <0.00%> (+0.12%) ⬆️
docarray/array/storage/qdrant/getsetdel.py 81.94% <0.00%> (+0.25%) ⬆️
docarray/array/storage/memory/find.py 91.22% <0.00%> (+0.31%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4213553...426539e. Read the comment docs.

@alaeddine-13 alaeddine-13 merged commit d85a597 into main May 26, 2022
@alaeddine-13 alaeddine-13 deleted the fix-protobuf-dependency branch May 26, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant