Skip to content

fix: update qdrant to support python 3.7#367

Merged
alaeddine-13 merged 1 commit into
mainfrom
test-old-main
May 24, 2022
Merged

fix: update qdrant to support python 3.7#367
alaeddine-13 merged 1 commit into
mainfrom
test-old-main

Conversation

@alaeddine-13

Copy link
Copy Markdown
Member

Revert "feat: make distance metric configurable in Weaviate backend"

@codecov

codecov Bot commented May 24, 2022

Copy link
Copy Markdown

Codecov Report

Merging #367 (68b7cb8) into main (e918f62) will increase coverage by 29.19%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #367       +/-   ##
===========================================
+ Coverage   56.98%   86.17%   +29.19%     
===========================================
  Files         134      134               
  Lines        6324     6324               
===========================================
+ Hits         3604     5450     +1846     
+ Misses       2720      874     -1846     
Flag Coverage Δ
docarray 86.17% <ø> (+29.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/base.py 98.64% <0.00%> (+2.70%) ⬆️
docarray/score/data.py 92.85% <0.00%> (+3.57%) ⬆️
docarray/array/mixins/io/from_gen.py 83.63% <0.00%> (+3.63%) ⬆️
docarray/document/mixins/porting.py 93.15% <0.00%> (+5.47%) ⬆️
docarray/math/ndarray.py 90.00% <0.00%> (+6.00%) ⬆️
docarray/array/mixins/match.py 75.00% <0.00%> (+6.25%) ⬆️
docarray/array/mixins/io/binary.py 97.45% <0.00%> (+7.00%) ⬆️
docarray/document/generators.py 86.32% <0.00%> (+7.69%) ⬆️
docarray/array/queryset/lookup.py 78.10% <0.00%> (+9.48%) ⬆️
docarray/proto/io/ndarray.py 94.95% <0.00%> (+10.92%) ⬆️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e918f62...68b7cb8. Read the comment docs.

@github-actions

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-test-old-main--jina-docs.netlify.app 🎉

@davidbp davidbp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I suspect you will add in the config the distance right?

@alaeddine-13 alaeddine-13 changed the title Revert "feat: make distance metric configurable in Weaviate backend" fix: update qdrant to support python 3.7 May 24, 2022
@alaeddine-13

Copy link
Copy Markdown
Member Author

LGTM, I suspect you will add in the config the distance right?

no it is not in relation to the distance parameter. I was just trying to revert to check why CI is breaking

@alaeddine-13 alaeddine-13 marked this pull request as ready for review May 24, 2022 13:34
@alaeddine-13 alaeddine-13 merged commit 4213553 into main May 24, 2022
@alaeddine-13 alaeddine-13 deleted the test-old-main branch May 24, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants