Skip to content

fix(windows): fix windows newline issue#364

Merged
hanxiao merged 1 commit into
mainfrom
fix-362
May 26, 2022
Merged

fix(windows): fix windows newline issue#364
hanxiao merged 1 commit into
mainfrom
fix-362

Conversation

@hanxiao

@hanxiao hanxiao commented May 24, 2022

Copy link
Copy Markdown
Member

closes: #362

@codecov

codecov Bot commented May 24, 2022

Copy link
Copy Markdown

Codecov Report

Merging #364 (d7f4f7b) into main (1e7ba61) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
- Coverage   86.19%   86.18%   -0.01%     
==========================================
  Files         134      134              
  Lines        6316     6321       +5     
==========================================
+ Hits         5444     5448       +4     
- Misses        872      873       +1     
Flag Coverage Δ
docarray 86.18% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/document/mixins/helper.py 70.00% <0.00%> (+2.55%) ⬆️
docarray/helper.py 76.56% <ø> (-0.10%) ⬇️
docarray/array/mixins/content.py 97.01% <66.66%> (-1.45%) ⬇️
docarray/array/storage/base/seqlike.py 80.76% <0.00%> (-7.70%) ⬇️
docarray/array/storage/weaviate/backend.py 86.50% <0.00%> (-0.89%) ⬇️
docarray/array/storage/elastic/backend.py 94.33% <0.00%> (ø)
docarray/array/mixins/io/pushpull.py 88.37% <0.00%> (+1.13%) ⬆️
docarray/array/storage/sqlite/seqlike.py 85.18% <0.00%> (+2.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e7ba61...d7f4f7b. Read the comment docs.

"""
if self:
content_type = self[0].content_type or self[-1].content_type
if isinstance(value, tuple) and len(value) == 2:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will make the interface complicated, is there a need for this ?

@hanxiao hanxiao merged commit 793fa71 into main May 26, 2022
@hanxiao hanxiao deleted the fix-362 branch May 26, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Got a "ValueError: binary mode doesn't take a newline argument" error when "save_image_tensor_to_file"

2 participants