Skip to content

fix: cryptographic random generator for weaviate classnames#357

Merged
alaeddine-13 merged 1 commit into
mainfrom
fix-classname-generator-weaviate
May 20, 2022
Merged

fix: cryptographic random generator for weaviate classnames#357
alaeddine-13 merged 1 commit into
mainfrom
fix-classname-generator-weaviate

Conversation

@alaeddine-13

Copy link
Copy Markdown
Member

closes: #352

@codecov

codecov Bot commented May 20, 2022

Copy link
Copy Markdown

Codecov Report

Merging #357 (b7ffc95) into main (f30b7e9) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   86.20%   86.17%   -0.04%     
==========================================
  Files         134      134              
  Lines        6323     6323              
==========================================
- Hits         5451     5449       -2     
- Misses        872      874       +2     
Flag Coverage Δ
docarray 86.17% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/__init__.py 100.00% <100.00%> (ø)
docarray/array/storage/weaviate/backend.py 86.50% <100.00%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51646bf...b7ffc95. Read the comment docs.

@davidbp davidbp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alaeddine-13 alaeddine-13 merged commit 2430125 into main May 20, 2022
@alaeddine-13 alaeddine-13 deleted the fix-classname-generator-weaviate branch May 20, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use a proper class name generator to avoid collisions

2 participants