Skip to content

feat(array): allow for type object with DocList#1829

Open
corentinmarek wants to merge 1 commit into
docarray:mainfrom
corentinmarek:allow_for_type_object_in_doclist
Open

feat(array): allow for type object with DocList#1829
corentinmarek wants to merge 1 commit into
docarray:mainfrom
corentinmarek:allow_for_type_object_in_doclist

Conversation

@corentinmarek

@corentinmarek corentinmarek commented Oct 31, 2023

Copy link
Copy Markdown

See issue #1828 for context

Signed-off-by: Corentin Marek <corentin.marek@gmail.com>

@JoanFM JoanFM left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May we add a test to show what is exactly what we are aiming to enable or disable?

@JoanFM JoanFM linked an issue Oct 31, 2023 that may be closed by this pull request
6 tasks
@codecov

codecov Bot commented Oct 31, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.37%. Comparing base (522811f) to head (1637c2b).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1829      +/-   ##
==========================================
- Coverage   85.05%   84.37%   -0.68%     
==========================================
  Files         135      135              
  Lines        9031     9031              
==========================================
- Hits         7681     7620      -61     
- Misses       1350     1411      +61     
Flag Coverage Δ
docarray 84.37% <ø> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DocList raises exception for type object.

2 participants