Skip to content

test: remove skip of s3 #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 1 commit into from
Sep 28, 2023
Merged

test: remove skip of s3 #1811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/integrations/store/test_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
from docarray import DocList
from docarray.documents import TextDoc
from docarray.store import S3DocStore
from docarray.utils._internal.pydantic import is_pydantic_v2
from tests.integrations.store import gen_text_docs, get_test_da, profile_memory

DA_LEN: int = 2**10
Expand Down Expand Up @@ -131,7 +130,6 @@ def test_pushpull_stream_correct(capsys):


# for some reason this test is failing with pydantic v2
@pytest.mark.skipif(is_pydantic_v2, reason="Not working with pydantic v2 for now")
@pytest.mark.slow
def test_pull_stream_vs_pull_full():
namespace_dir = f'{BUCKET}/test{RANDOM}/pull-stream-vs-pull-full'
Expand Down