Skip to content

fix(weaviate): remove ndim requirement in weaviate#159

Merged
hanxiao merged 7 commits into
mainfrom
fix-ndim-weaviate
Feb 28, 2022
Merged

fix(weaviate): remove ndim requirement in weaviate#159
hanxiao merged 7 commits into
mainfrom
fix-ndim-weaviate

Conversation

@hanxiao

@hanxiao hanxiao commented Feb 28, 2022

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Feb 28, 2022

Copy link
Copy Markdown

Codecov Report

Merging #159 (77ee8d1) into main (454fce0) will decrease coverage by 0.02%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   84.45%   84.43%   -0.03%     
==========================================
  Files         115      115              
  Lines        4993     4993              
==========================================
- Hits         4217     4216       -1     
- Misses        776      777       +1     
Flag Coverage Δ
docarray 84.43% <89.47%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/weaviate/backend.py 86.32% <80.00%> (-1.18%) ⬇️
docarray/array/storage/base/getsetdel.py 92.03% <100.00%> (+0.07%) ⬆️
docarray/array/storage/weaviate/getsetdel.py 100.00% <100.00%> (ø)
docarray/array/storage/weaviate/find.py 89.74% <0.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 454fce0...77ee8d1. Read the comment docs.

@github-actions

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-fix-ndim-weaviate--jina-docs.netlify.app 🎉

@hanxiao hanxiao merged commit 78cadd0 into main Feb 28, 2022
@hanxiao hanxiao deleted the fix-ndim-weaviate branch February 28, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant