Skip to content

feat: read from remote csv file#1362

Merged
samsja merged 5 commits into
feat-rewrite-v2from
feat-csv-from-remote-file
Apr 12, 2023
Merged

feat: read from remote csv file#1362
samsja merged 5 commits into
feat-rewrite-v2from
feat-csv-from-remote-file

Conversation

@anna-charlotte

Copy link
Copy Markdown
Contributor

Goals:

Currently, only local urls work. Let's allow remote ones too

  • check and update documentation, if required. See guide

Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
@anna-charlotte anna-charlotte requested a review from samsja April 12, 2023 06:56
@anna-charlotte anna-charlotte marked this pull request as ready for review April 12, 2023 06:56
Comment thread docarray/array/doc_list/io.py Outdated

@samsja samsja left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment

anna-charlotte added 3 commits April 12, 2023 09:14
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Signed-off-by: anna-charlotte <charlotte.gerhaher@jina.ai>
Comment thread docarray/array/doc_list/io.py Outdated
@github-actions

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-feat-csv-from-remote-file--jina-docs.netlify.app 🎉

@samsja samsja merged commit 95c1eca into feat-rewrite-v2 Apr 12, 2023
@samsja samsja deleted the feat-csv-from-remote-file branch April 12, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants