Skip to content

refactor: rename from_pandas to from_dataframe#1358

Merged
samsja merged 3 commits into
feat-rewrite-v2from
refactor-rename-pandas
Apr 12, 2023
Merged

refactor: rename from_pandas to from_dataframe#1358
samsja merged 3 commits into
feat-rewrite-v2from
refactor-rename-pandas

Conversation

@samsja

@samsja samsja commented Apr 11, 2023

Copy link
Copy Markdown
Member

Context

rename from_pandas to from_dataframe

Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
@anna-charlotte

Copy link
Copy Markdown
Contributor

maybe same for .to_pandas() -> .to_dataframe()

@samsja

samsja commented Apr 11, 2023

Copy link
Copy Markdown
Member Author

maybe same for .to_pandas() -> .to_dataframe()

good point

Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
@samsja samsja requested a review from anna-charlotte April 11, 2023 15:05
@github-actions github-actions Bot added size/s and removed size/xs labels Apr 11, 2023

@anna-charlotte anna-charlotte left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you adjust it in the docstrings accordingly, too, other than that lgtm

@samsja

samsja commented Apr 11, 2023

Copy link
Copy Markdown
Member Author

yes ofc my bad

Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
@github-actions

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-refactor-rename-pandas--jina-docs.netlify.app 🎉

@samsja samsja marked this pull request as ready for review April 12, 2023 08:05
@samsja samsja merged commit 18ad2ea into feat-rewrite-v2 Apr 12, 2023
@samsja samsja deleted the refactor-rename-pandas branch April 12, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants