Skip to content

refactor: rename DocArray to DocList#1334

Merged
samsja merged 27 commits into
feat-rewrite-v2from
refactor-rename-docarray-var
Apr 4, 2023
Merged

refactor: rename DocArray to DocList#1334
samsja merged 27 commits into
feat-rewrite-v2from
refactor-rename-docarray-var

Conversation

@samsja

@samsja samsja commented Apr 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Context

rename DocArray to DocList

rename DocArrayStack to DocVec
AnyDocArray stay the same

@github-actions

github-actions Bot commented Apr 3, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@jupyterjazz

jupyterjazz commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

I'd say DocArrayStacked to DocListStacked or DocStack, and AnyDocArray to AnyDocList.
Do we have a discussion on this somewhere?

@jupyterjazz jupyterjazz linked an issue Apr 3, 2023 that may be closed by this pull request
Rename variable #1231
Closed
@github-actions

github-actions Bot commented Apr 3, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

5 similar comments
@github-actions

github-actions Bot commented Apr 3, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions

github-actions Bot commented Apr 3, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions

github-actions Bot commented Apr 3, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions

github-actions Bot commented Apr 3, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions

github-actions Bot commented Apr 3, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@samsja samsja force-pushed the refactor-rename-docarray-var branch from fe0fc26 to 1edec0c Compare April 3, 2023 14:39
@github-actions

github-actions Bot commented Apr 3, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@samsja samsja marked this pull request as ready for review April 3, 2023 14:39
@github-actions

github-actions Bot commented Apr 3, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions

github-actions Bot commented Apr 3, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions

github-actions Bot commented Apr 3, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions

github-actions Bot commented Apr 3, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

anna-charlotte
anna-charlotte reviewed Apr 4, 2023
View reviewed changes
Comment thread docarray/store/abstract_doc_store.py Outdated
@samsja
refactor: rename da to docs
9659e38 
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
@github-actions

github-actions Bot commented Apr 4, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@samsja
refactor: rename da columns to docs_vec_colunn
4e3a31b 
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
@github-actions

github-actions Bot commented Apr 4, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

anna-charlotte
anna-charlotte reviewed Apr 4, 2023
View reviewed changes
Comment thread README.md Outdated
anna-charlotte
anna-charlotte reviewed Apr 4, 2023
View reviewed changes
Comment thread docarray/index/abstract.py Outdated
anna-charlotte
anna-charlotte reviewed Apr 4, 2023
View reviewed changes
Comment thread docarray/store/abstract_doc_store.py Outdated
@samsja
fix: fix readme
9b1a9a7 
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
anna-charlotte
anna-charlotte reviewed Apr 4, 2023
View reviewed changes
Comment thread docarray/store/file.py Outdated
@github-actions

github-actions Bot commented Apr 4, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

anna-charlotte
anna-charlotte reviewed Apr 4, 2023
View reviewed changes
Comment thread docarray/store/file.py Outdated
@samsja
fix: rename last da
a4cda60 
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
anna-charlotte
anna-charlotte reviewed Apr 4, 2023
View reviewed changes
Comment thread docarray/store/s3.py Outdated
@github-actions

github-actions Bot commented Apr 4, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@samsja
fix: rename last da
6b8f30d 
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
@github-actions

github-actions Bot commented Apr 4, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@samsja
fix: fic docs nested da stack
4c2d286 
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
@samsja samsja requested a review from anna-charlotte April 4, 2023 11:54
@github-actions

github-actions Bot commented Apr 4, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@samsja
fix: fix becmark
1852b70 
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
@github-actions

github-actions Bot commented Apr 4, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@samsja
fix: fix docsm ap
408736c 
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
@github-actions

github-actions Bot commented Apr 4, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@samsja
fix: fix docsm ap
cbc1598 
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
@github-actions

github-actions Bot commented Apr 4, 2023

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions

github-actions Bot commented Apr 4, 2023

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-refactor-rename-docarray-var--jina-docs.netlify.app 🎉

@samsja samsja merged commit a74b3bb into feat-rewrite-v2 Apr 4, 2023
@samsja samsja deleted the refactor-rename-docarray-var branch April 4, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohannesMessner JohannesMessner Awaiting requested review from JohannesMessner

@JoanFM JoanFM Awaiting requested review from JoanFM

@jupyterjazz jupyterjazz Awaiting requested review from jupyterjazz

@anna-charlotte anna-charlotte Awaiting requested review from anna-charlotte

Assignees

No one assigned

Labels

area/cicd area/core area/docs area/entrypoint area/housekeeping area/testing area/typing component/array component/proto size/xl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename variable

3 participants

@samsja @jupyterjazz @anna-charlotte