feat: add validate search field method#1319
Merged
jupyterjazz merged 2 commits intoApr 3, 2023
Merged
Conversation
Member
|
We should have a special case for search fields that are empty ( |
Contributor
Author
@JohannesMessner Mind creating a new issue just in case it's a priority so I can fix work on it? |
Contributor
|
@srini047 I took over your PR, thanks for the contribution |
samsja
pushed a commit
that referenced
this pull request
Apr 11, 2023
* refactor: dummy change Signed-off-by: jupyterjazz <saba.sturua@jina.ai> * feat: add validate search field method (#1319) Co-authored-by: Saba Sturua <45267439+jupyterjazz@users.noreply.github.com> * feat: validate search fields Signed-off-by: jupyterjazz <saba.sturua@jina.ai> * refactor: validate fields in es Signed-off-by: jupyterjazz <saba.sturua@jina.ai> --------- Signed-off-by: jupyterjazz <saba.sturua@jina.ai> Co-authored-by: Sriniketh J <81156510+srini047@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1264
Goals: