-
Notifications
You must be signed in to change notification settings - Fork 244
feat: add minimal logger #1254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: add minimal logger #1254
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e9ab146
feat: add minimal logger
jupyterjazz 48ab108
docs: add an example in contributing
jupyterjazz 2fe912c
docs: try different format
jupyterjazz 4a78108
refactor: set one logger name
jupyterjazz a61eac2
docs: add quotes
jupyterjazz 8c243e1
refactor: put logger as a class attr
jupyterjazz 18fb7e8
Merge branch 'feat-rewrite-v2' into feat-add-minimal-logger
jupyterjazz f75d287
docs: small change
jupyterjazz 9de7e6d
refactor: requested changes
jupyterjazz 6262ff3
fix: typo
jupyterjazz 4af827a
Merge branch 'feat-rewrite-v2' into feat-add-minimal-logger
jupyterjazz 744176a
docs: rephrase text
jupyterjazz 9ae165f
refactor: requested changes
jupyterjazz 18b21f0
Merge branch 'feat-rewrite-v2' into feat-add-minimal-logger
jupyterjazz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import pytest | ||
| import logging | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True) | ||
| def set_logger_level(): | ||
| logger = logging.getLogger('docarray') | ||
| logger.setLevel(logging.INFO) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.