-
Notifications
You must be signed in to change notification settings - Fork 244
change return type of find_batched() utility function #1310
Copy link
Copy link
Closed
Labels
DocArray v2This issue is part of the rewrite; not to be merged into mainThis issue is part of the rewrite; not to be merged into maingood-first-issueSuitable as your first contribution to DocArray!Suitable as your first contribution to DocArray!
Metadata
Metadata
Assignees
Labels
DocArray v2This issue is part of the rewrite; not to be merged into mainThis issue is part of the rewrite; not to be merged into maingood-first-issueSuitable as your first contribution to DocArray!Suitable as your first contribution to DocArray!
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
StatusShow more project fields
Done
Currently,
find_batched()has the following signature:In order to align with
DocumentIndex, it should be switched to:TODOs:
FindResultBatchedfromindex/abstract.pytoutils/find.pyFindResultBatchedneeds a tweak as well:scores: np.ndarrayprobably needs to be changed to allow a union of ndarray, torch.Tensor and tf.Tensor