-
Notifications
You must be signed in to change notification settings - Fork 244
remove validation of url file extensions #1309
Copy link
Copy link
Closed
Labels
DocArray v2This issue is part of the rewrite; not to be merged into mainThis issue is part of the rewrite; not to be merged into maingood-first-issueSuitable as your first contribution to DocArray!Suitable as your first contribution to DocArray!
Metadata
Metadata
Assignees
Labels
DocArray v2This issue is part of the rewrite; not to be merged into mainThis issue is part of the rewrite; not to be merged into maingood-first-issueSuitable as your first contribution to DocArray!Suitable as your first contribution to DocArray!
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
StatusShow more project fields
Done
Currently, our
Urltypes likeImageUrl,VideoUrletc are performing validation based on the file extension: only file extensions of that modality are allowed.However, that is problematic since we cannot catch all edge cases. For example, http://lh6.ggpht.com/-IvRtNLNcG8o/TpFyrudaT6I/AAAAAAAAM6o/_11MuAAKalQ/IMG_3422.JPG?imgmax=800 is a completly valid image url, but currently our validation will fail it, because the extension is not "valid".
We could fix this edge case, but the general problem remains: We are not confident that we can handle all edge cases for all data modalities, and failing validation where it should not can be a serious blocker for users.
So, we decided to remove file extension validation for all or our
Urltypes.