Skip to content

remove validation of url file extensions #1309

@JohannesMessner

Description

@JohannesMessner

Currently, our Url types like ImageUrl, VideoUrl etc are performing validation based on the file extension: only file extensions of that modality are allowed.

However, that is problematic since we cannot catch all edge cases. For example, http://lh6.ggpht.com/-IvRtNLNcG8o/TpFyrudaT6I/AAAAAAAAM6o/_11MuAAKalQ/IMG_3422.JPG?imgmax=800 is a completly valid image url, but currently our validation will fail it, because the extension is not "valid".

We could fix this edge case, but the general problem remains: We are not confident that we can handle all edge cases for all data modalities, and failing validation where it should not can be a serious blocker for users.

So, we decided to remove file extension validation for all or our Url types.

Metadata

Metadata

Assignees

Labels

DocArray v2This issue is part of the rewrite; not to be merged into maingood-first-issueSuitable as your first contribution to DocArray!

Type

No type
No fields configured for issues without a type.

Projects

Status
Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions