Skip to content

Add env variable that allows to skip the certificate validation in go…#649

Open
trading-peter wants to merge 1 commit into
dnote:masterfrom
trading-peter:feat_skip_tls_verify
Open

Add env variable that allows to skip the certificate validation in go…#649
trading-peter wants to merge 1 commit into
dnote:masterfrom
trading-peter:feat_skip_tls_verify

Conversation

@trading-peter
Copy link
Copy Markdown

…mail

My mail smtp uses letsencrypt and apparently gomail doesn't verify TLS connection to it as valid because the certificate issued by LE doesn't seem to hold the whole chain. I've added additional env variable to force gomail to skip that check.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 25, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sungwoncho
Copy link
Copy Markdown
Member

sungwoncho commented Jan 28, 2024

Hi @trading-peter, it sounds reasonable. Would you be able to agree with the CLA? I will try to cut a new release with this.

@sungwoncho
Copy link
Copy Markdown
Member

Hi @trading-peter, Dnote now doesn't require CLA and uses a more permissive Apache 2.0 license. If you would like to give this another go (there's a merge conflict), let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants