FIX: False permission change logs in non-English forums #36676
+31
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/everyone-group-in-category-permissions-in-non-english-forums/335600/15 |
When saving a category with default "everyone" permissions in non-English forums, staff action logs incorrectly showed a permission change even when nothing changed. The issue occurred because the backend fallback for empty permissions used the hardcoded English string "everyone", but the frontend sends the localized group name (e.g., "jeder" in German). This mismatch triggered false log entries. Changed the fallback in categories_controller.rb to use Group[:everyone].name which returns the actual localized group name from the database. Ref - https://meta.discoure.org/t/335600/14
8e6b8cc to
7148dba
Compare
tannerabread
approved these changes
Dec 14, 2025
7148dba to
5d8601a
Compare
Comment on lines
4
to
5
| fab!(:admin) | ||
| fab!(:category) { Fabricate(:category, user: admin) } | ||
| let(:admin) { Fabricate(:admin) } | ||
| let!(:category) { Fabricate(:category, user: admin) } |
Contributor
There was a problem hiding this comment.
Do you mind explaining why you had to put this back?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving a category with default "everyone" permissions in non-English forums, staff action logs incorrectly showed a permission change even when nothing changed.
The issue occurred because the backend fallback for empty permissions used the hardcoded English string "everyone", but the frontend sends the localized group name (e.g., "jeder" in German). This mismatch triggered false log entries.
Changed the fallback in categories_controller.rb to use Group[:everyone].name which returns the actual localized group name from the database.
Ref - https://meta.discoure.org/t/335600/14