UX: Sort admin sidebar plugin links alphabetically #36674
+117
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Ah never mind, we will get the translated name only on client. I guess given we don't paginate we could return a list already translated/sorted though. |
Plugins in the admin sidebar were displayed in an unpredictable order based on plugin load sequence, making it difficult for admins to locate specific plugins as their number grows. Additionally, plugin display names were inconsistent - the server-side `humanized_name` stripped the "Discourse" prefix, but client-side translated labels (e.g., "Discourse Footnotes") retained it. Changes: - Sort plugin links alphabetically by translated display name using `localeCompare` for i18n support, with plugin name as tiebreaker - Add `stripDiscoursePrefix` utility to remove "Discourse " or "discourse-" prefixes (case-insensitive) - Update server-side `humanized_name` to use regex `/\Adiscourse[\s-]+/i` instead of chained `delete_prefix` calls - Apply prefix stripping to sidebar link text and plugin settings page titles (via `nameTitleized` getter)
461077b to
9ecf9ce
Compare
Member
Author
Except the translations are only available on the client side 🤔 |
Add null/undefined guard to prevent "Cannot read properties of undefined (reading 'replace')" errors when text is not provided.
efcccb3 to
709e825
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins in the admin sidebar were displayed in an unpredictable order based on load sequence. This makes it harder for admins to find specific plugins, especially as the number of installed plugins grows.
Sort plugin links alphabetically by their translated display name, with the internal plugin name as a secondary sort key for stability.
The sorting uses localeCompare for proper internationalization support.
BEFORE
AFTER