Skip to content

DEV: Pass upload id from object site setting #36665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
janzenisaac merged 2 commits into from
Dec 15, 2025
Merged

DEV: Pass upload id from object site setting #36665

janzenisaac merged 2 commits into from
Dec 15, 2025
+32 −25

Conversation

@janzenisaac
Copy link
Contributor

@janzenisaac janzenisaac commented Dec 12, 2025 •
edited
Loading

This PR contains two improvements:

  1. Instead of needing a ton of logic to normalize / validate upload inputs in object site settings, we can pass the ID of the upload instead of the URL. This saves us extra conditionals and simplifies the code.
  2. The core standard for storing uploads in the DB is by ID. The uploads in object site settings were being stored as a path (string), this PR aligns with the core standard.

@janzenisaac janzenisaac merged commit 36a1589 into main Dec 15, 2025
16 checks passed
@janzenisaac janzenisaac deleted the pass-upload-id-from-object-site-setting branch December 15, 2025 15:01
@janzenisaac janzenisaac mentioned this pull request Dec 15, 2025
Draft
janzenisaac added a commit that referenced this pull request Dec 15, 2025
@janzenisaac
Revert "DEV: Pass upload id from object site setting (#36665)"
6235f3c 
This reverts commit 36a1589.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Grubba27 Grubba27 Grubba27 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janzenisaac @Grubba27