-
Notifications
You must be signed in to change notification settings - Fork 8.7k
FEATURE: create tags inline on the /tags route #36645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ZogStriP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏷️
martin-brennan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the service, I think splitting into 2 steps is the last thing to do here then go ahead + merge 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds functionality to create tags directly from the /tags route through an inline form, providing admins with a more convenient way to create multiple tags without navigating to a separate upload page.
Key changes:
- Implements a new
Tags::BulkCreateservice for handling bulk tag creation with validation - Adds an auto-expanding textarea input to the /tags index page for inline tag creation
- Displays detailed results showing created, existing, and failed tags after submission
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/services/tags/bulk_create_spec.rb | Comprehensive test coverage for the new bulk create service |
| app/services/tags/bulk_create.rb | Service implementation for bulk tag creation with validation and result tracking |
| app/controllers/tags_controller.rb | Controller action to handle bulk create API endpoint |
| frontend/discourse/app/controllers/tags/index.js | Frontend controller logic for form submission and result handling |
| frontend/discourse/app/templates/tags/index.gjs | UI template with inline creation form and results display |
| config/routes.rb | New route for bulk create endpoint |
| config/locales/server.en.yml | Server-side error messages for bulk create |
| config/locales/client.en.yml | Client-side UI strings for bulk create feature |
| app/assets/stylesheets/common/base/tagging.scss | Styles for the inline form and results display |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This pull request has been mentioned on Discourse Meta. There might be relevant details there: https://meta.discourse.org/t/you-can-now-create-new-tags-on-the-tags-page/391475/1 |
This adds an auto-expanding input to the /tags route that allows admins to create new tags and creates a new bulk_create tag service