DEV: Add tests for embed mode functionality

xfalcox · claude · xfalcox · commit f3fc3741b9a5 · 2025-12-12T15:21:04.000-03:00
Request specs: - Verify X-Frame-Options header is kept without embed_mode param - Verify X-Frame-Options header is kept with invalid referer - Verify X-Frame-Options header is stripped with valid embeddable host - Verify X-Frame-Options header is stripped with embed_any_origin setting System specs: - Verify embed-mode class is applied to body with embed_mode=true - Verify embed-mode class is not applied without the param - Verify suggested topics are hidden in embed mode - Verify topic content loads without JS errors 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
diff --git a/spec/requests/application_controller_spec.rb b/spec/requests/application_controller_spec.rb
@@ -662,6 +662,40 @@
     end
   end
 
+  describe "allow_embed_mode" do
+    fab!(:topic)
+
+    it "keeps X-Frame-Options when embed_mode param is missing" do
+      get("/t/#{topic.slug}/#{topic.id}")
+      expect(response.headers["X-Frame-Options"]).to eq("SAMEORIGIN")
+    end
+
+    it "keeps X-Frame-Options when embed_mode is present but referer is invalid" do
+      get("/t/#{topic.slug}/#{topic.id}", params: { embed_mode: "true" })
+      expect(response.headers["X-Frame-Options"]).to eq("SAMEORIGIN")
+    end
+
+    it "strips X-Frame-Options when embed_mode is present and referer matches embeddable host" do
+      Fabricate(:embeddable_host, host: "example.com")
+      get(
+        "/t/#{topic.slug}/#{topic.id}",
+        params: {
+          embed_mode: "true",
+        },
+        headers: {
+          "HTTP_REFERER" => "https://example.com/page",
+        },
+      )
+      expect(response.headers).not_to include("X-Frame-Options")
+    end
+
+    it "strips X-Frame-Options when embed_mode is present and embed_any_origin is enabled" do
+      SiteSetting.embed_any_origin = true
+      get("/t/#{topic.slug}/#{topic.id}", params: { embed_mode: "true" })
+      expect(response.headers).not_to include("X-Frame-Options")
+    end
+  end
+
   describe "setting `Cross-Origin-Opener-Policy` header" do
     describe "when `cross_origin_opener_policy_header` site setting is set to `same-origin`" do
       before { SiteSetting.cross_origin_opener_policy_header = "same-origin" }
diff --git a/spec/system/embed_mode_spec.rb b/spec/system/embed_mode_spec.rb
@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+describe "Embed mode", type: :system do
+  fab!(:topic)
+  fab!(:post) { Fabricate(:post, topic: topic) }
+
+  let(:topic_page) { PageObjects::Pages::Topic.new }
+
+  it "applies embed-mode class to body when embed_mode=true" do
+    visit("/t/#{topic.slug}/#{topic.id}?embed_mode=true")
+
+    expect(page).to have_css("body.embed-mode")
+  end
+
+  it "does not apply embed-mode class without the param" do
+    visit("/t/#{topic.slug}/#{topic.id}")
+
+    expect(page).to have_no_css("body.embed-mode")
+  end
+
+  it "hides suggested topics in embed mode" do
+    Fabricate(:post) # create another topic for suggestions
+    visit("/t/#{topic.slug}/#{topic.id}?embed_mode=true")
+
+    expect(page).to have_css("body.embed-mode")
+    expect(page).to have_no_css(".suggested-topics")
+  end
+
+  it "loads topic content without JS errors" do
+    visit("/t/#{topic.slug}/#{topic.id}?embed_mode=true")
+
+    expect(page).to have_css("body.embed-mode")
+    expect(topic_page).to have_topic_title(topic.title)
+    expect(page).to have_css("#post_1")
+  end
+end
