Draft
Conversation
…ent and override in css
…ing + add half-steps
TODO the tokens get generated, but aren't connected in Figma (you have to manually re-apply them). Maybe due to not being in the same mode?
…ctured and we have backward-compatibility layer
…e>/<theme>/<font> tokens
|
Contributor
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a further development of #4044. While that has no breaking changes, it only allows configuring sizing for all themes/typography.
This change will be breaking for people who have started to use typography modes (primary/secondary) since those have been removed. It will also require some changes in the Figma Core UI Kit. However, I feel this is a much better path to take for supporting multiple fonts, and not many people have used typography modes yet due to it being half-baked so far with no config support.
Details
Example
designsystemet.config.jsonRemaining work
Further work is required before this is ready:
line-heightandletter-spacingto configurationChecks
pnpm changesetif relevant)