Conversation
🦋 Changeset detectedLatest commit: b35b20f The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Member
|
Can you add a story for each placement in Storybook? So we get visual tests for it |
Co-authored-by: Tobias Barsnes <tobias.barsnes@digdir.no>
Co-authored-by: Tobias Barsnes <tobias.barsnes@digdir.no>
Co-authored-by: Tobias Barsnes <tobias.barsnes@digdir.no>
Co-authored-by: Tobias Barsnes <tobias.barsnes@digdir.no>
Co-authored-by: Tobias Barsnes <tobias.barsnes@digdir.no>
Barsnes
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #4322
Notes:
topandbottomretains border-radius in the content-facing direction when non-modal if there is a scrollbar present. I could make a media query where the "buffer" in the calculation that triggers the switch to 0 is increased to 17px to account for the scrollbar on wider viewports but i feel like this is unneccessary ref the github sidesheet discussion (being a part of the layout vs overlaying the layout)topandbottomhas border on the sides in case the user wants to reduce the max-width to less than 100%. I have not figured a way to auto-toggle the inline-border based on dialog-width vs viewport width yet (perhaps a progressive enhancement with if() or container style query is possible)