Skip to content

fix(Popover): open state going out of sync#4314

Merged
Barsnes merged 2 commits intomainfrom
popover/control
Dec 12, 2025
Merged

fix(Popover): open state going out of sync#4314
Barsnes merged 2 commits intomainfrom
popover/control

Conversation

@Barsnes
Copy link
Member

@Barsnes Barsnes commented Dec 11, 2025

Summary

REPORTED ON EMAIL:

Bug: Popover/Dropdown med kontrollert state - race condition ved item-click
Problem: Når Popover/Dropdown brukes med kontrollert state (open prop) og brukeren klikker på et item, oppstår en race condition som gjør at menyen ikke lukker seg konsistent ved påfølgende klikk utenfor (annenhver gang).
Rot-årsak: I packages/react/src/components/popover/popover.tsx linje 135-141 setter handleClick setInternalOpen(false) selv når open prop er kontrollert. Dette skaper en mismatch mellom open prop og internalOpen state.
Løsning: Popover bør kun sette internalOpen når open prop ikke er satt.

Checks

@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2025

🦋 Changeset detected

Latest commit: 0629752

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@digdir/designsystemet-react Patch
@digdir/designsystemet Patch
@digdir/designsystemet-css Patch
@digdir/designsystemet-theme Patch
@digdir/designsystemet-types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Barsnes Barsnes marked this pull request as ready for review December 11, 2025 14:15
@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

Preview deployments for this pull request:

storybook - 12. Dec 2025 - 08:03

@Barsnes Barsnes marked this pull request as draft December 11, 2025 15:13
Co-authored-by: Åsmund Skålevik <aasmund.skaalevik@hi.no>
@Barsnes Barsnes changed the title fix(Popover): open race condition fix(Popover): open state going out of sync Dec 12, 2025
@Barsnes Barsnes marked this pull request as ready for review December 12, 2025 07:00
@Barsnes Barsnes merged commit e3f7e57 into main Dec 12, 2025
19 checks passed
@Barsnes Barsnes deleted the popover/control branch December 12, 2025 10:50
@github-actions github-actions bot mentioned this pull request Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants