Skip to content

feat(use-pagination): hide prev/next button instead of disabling #4123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Barsnes merged 7 commits into from
Oct 8, 2025
Merged

feat(use-pagination): hide prev/next button instead of disabling #4123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
12b9f9e
feat(use-pagination): hide prev/next button instead of disabling
Barsnes Oct 7, 2025
87fd8ee
use visibility
Barsnes Oct 7, 2025
a38a938
add it to css
Barsnes Oct 7, 2025
bcedddf
Create six-grapes-jump.md
Barsnes Oct 7, 2025
d3114ea
Create neat-houses-think.md
Barsnes Oct 7, 2025
06a5534
update tests
Barsnes Oct 7, 2025
48dbb0e
fix typos
Barsnes Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/neat-houses-think.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@digdir/designsystemet-css": patch
---

**pagination**: If direct child of `li` has `aria-hidden="true"` it sets `visibility: hidden;`
5 changes: 5 additions & 0 deletions .changeset/six-grapes-jump.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@digdir/designsystemet-react": patch
---

**usePagination**: Hide prev/next buttons with `aria-hidden="true"` and `visibility: hidden;` instead of disabling
4 changes: 4 additions & 0 deletions packages/css/src/pagination.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@
display: flex;
}

& > li > [aria-hidden='true'] {
visibility: hidden;
}

& > li:first-child > ::before,
& > li:last-child > ::before {
content: '';
Expand Down
16 changes: 8 additions & 8 deletions packages/react/src/utilities/hooks/use-pagination/use-pagination.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,29 +37,29 @@ describe('usePagination', () => {
}
});

it('should prevet previous when at start', () => {
it('should prevent previous when at start', () => {
const { result } = renderHook(() =>
usePagination({ totalPages: 10, currentPage: 1 }),
);

expect(result.current.hasPrev).toBe(false);
expect(result.current.hasNext).toBe(true);
expect(result.current.prevButtonProps['aria-disabled']).toBe(true);
expect(result.current.nextButtonProps['aria-disabled']).toBe(false);
expect(result.current.prevButtonProps['aria-hidden']).toBe(true);
expect(result.current.nextButtonProps['aria-hidden']).toBe(false);
});

it('should prevet next when at end', () => {
it('should prevent next when at end', () => {
const { result } = renderHook(() =>
usePagination({ totalPages: 10, currentPage: 10 }),
);

expect(result.current.hasPrev).toBe(true);
expect(result.current.hasNext).toBe(false);
expect(result.current.prevButtonProps['aria-disabled']).toBe(false);
expect(result.current.nextButtonProps['aria-disabled']).toBe(true);
expect(result.current.prevButtonProps['aria-hidden']).toBe(false);
expect(result.current.nextButtonProps['aria-hidden']).toBe(true);
});

it('should trigger onChange when clickinging button', async () => {
it('should trigger onChange when clicking button', async () => {
const mockOnChange = vi.fn();
const event = { preventDefault: () => {} } as MouseEvent<HTMLButtonElement>;
const { result } = renderHook(() =>
Expand All @@ -71,7 +71,7 @@ describe('usePagination', () => {
expect(mockOnChange).toHaveBeenCalledWith(event, 2);
});

it('should not trigger onChange when clickinging previous button and in start', async () => {
it('should not trigger onChange when clicking previous button and in start', async () => {
const mockOnChange = vi.fn();
const event = { preventDefault: () => {} } as MouseEvent<HTMLButtonElement>;
const { result } = renderHook(() =>
Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/utilities/hooks/use-pagination/use-pagination.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,13 @@ export const usePagination = ({
),
/** Properties to spread on Pagination.Button used for previous naviagation */
prevButtonProps: {
'aria-disabled': !hasPrev, // Using aria-disabled to support all HTML elements because of potential asChild
'aria-hidden': !hasPrev, // Using aria-hidden to support all HTML elements because of potential asChild
onClick: handleClick(currentPage - 1),
variant: 'tertiary',
} as PaginationButtonProps,
/** Properties to spread on Pagination.Button used for next naviagation */
nextButtonProps: {
'aria-disabled': !hasNext, // Using aria-disabled to support all HTML elements because of potential asChild
'aria-hidden': !hasNext, // Using aria-hidden to support all HTML elements because of potential asChild
onClick: handleClick(currentPage + 1),
variant: 'tertiary',
} as PaginationButtonProps,
Expand Down
Loading