feat(design-tokens): restructure tokens, option to override severity#4105
Merged
feat(design-tokens): restructure tokens, option to override severity#4105
Conversation
🦋 Changeset detectedLatest commit: df526f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Preview deployments for this pull request: storybook - |
oddvernes
reviewed
Oct 3, 2025
.changeset/selfish-carrots-roll.md
Outdated
| - Moved severity colors directly to your theme file | ||
| - `"link.color.visited"` now references `"$value": "color.link.visited"` from your theme file | ||
|
|
||
| Make sure to update your design tokens |
Collaborator
There was a problem hiding this comment.
Perhaps this should be more explicit, "Make sure to regenerate your design tokens with the cli" or something like that
Member
Author
There was a problem hiding this comment.
Yeah, I'll update with the actual command :)
oddvernes
approved these changes
Oct 3, 2025
Collaborator
oddvernes
left a comment
There was a problem hiding this comment.
Looks good to me, but you may want input from others as well 👍
This was referenced Oct 7, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolves #3533
resolves #3522
This PR removes the need for a
global.jsonfile.It moves all global colors to the theme file, and removes the need for names such as "red".
It also removes the need for "purple", and now directly generates the "scale" for link visited. We still use the same purple hex code, to make sure future changes to our color values will be reflected.
As a bonus, I extended our overrides to allow
"severityColors"Checks
pnpm changesetif relevant)