Skip to content

fix(textfield): change validation message order#4104

Merged
Barsnes merged 2 commits intodigdir:mainfrom
poi33:feat/error-message-order
Oct 1, 2025
Merged

fix(textfield): change validation message order#4104
Barsnes merged 2 commits intodigdir:mainfrom
poi33:feat/error-message-order

Conversation

@poi33
Copy link
Collaborator

@poi33 poi33 commented Sep 30, 2025 •
edited by Barsnes
Loading

Summary

Updated Textfield changed count and error validation messages order

resolves #4101

Checks

@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 0bf623e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@digdir/designsystemet-react Patch
@digdir/designsystemet Patch
@digdir/designsystemet-css Patch
@digdir/designsystemet-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Barsnes
Barsnes requested changes Sep 30, 2025
View reviewed changes
Copy link
Member

@Barsnes Barsnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to make sure the changes you made are formatted using biome
See the failing "checks" action

oddvernes
oddvernes reviewed Oct 1, 2025
View reviewed changes
@Barsnes Barsnes changed the title feat(textfield): change validation message order (#4101) fix(textfield): change validation message order Oct 1, 2025
@poi33 poi33 force-pushed the feat/error-message-order branch 3 times, most recently from a99f1aa to 882bf4c Compare October 1, 2025 08:39
@poi33 poi33 force-pushed the feat/error-message-order branch from 882bf4c to 07c36a4 Compare October 1, 2025 08:42
@Barsnes
Copy link
Member

Barsnes commented Oct 1, 2025 •
edited
Loading

You need to add a new commit to the branch, since I updated your title from feat to fix.
If you don't, we wont be able to squash the PR into a commit with the title

Easiest fix is to just click "Update branch"

@poi33
Copy link
Collaborator Author

poi33 commented Oct 1, 2025 •
edited
Loading

You need to add a new commit to the branch, since I updated your title from feat to fix. If you don't, we wont be able to squash the PR into a commit with the title

Easiest fix is to just click "Update branch"

Was wondering why the commit did not pass all tests 👍

@Barsnes Barsnes merged commit 4c5c489 into digdir:main Oct 1, 2025
5 of 6 checks passed
@github-actions github-actions bot mentioned this pull request Oct 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oddvernes oddvernes oddvernes left review comments

@Barsnes Barsnes Barsnes approved these changes

@mimarz mimarz Awaiting requested review from mimarz mimarz is a code owner

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Character counter message should stay on top when combined with error messages

3 participants

@poi33 @Barsnes @oddvernes