fvirga/new annotation unit tests#1541
Merged
anthony-chaudhary merged 10 commits intomasterfrom Oct 20, 2023
Merged
Conversation
francescov1
commented
Aug 31, 2023
| @@ -125,69 +125,69 @@ def test_update_sequence_id_in_cache_list(self): | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
Nothing has actually changed in this file, I just re-ordered the tests so that test cases for the same methods are grouped together
francescov1
commented
Aug 31, 2023
| mock_get_member.assert_not_called() # Member was not fetched | ||
|
|
||
| # TODO: This isnt working, got it from here https://stackoverflow.com/questions/32463321/how-to-assert-method-call-order-with-python-mock | ||
| # func_calls.assert_has_calls([call.m1(), call.m2(), call.m3(), call.m4(), call.m5(), call.m6()]) |
Contributor
Author
There was a problem hiding this comment.
Wanted to add an assert to ensure we call each of these functions in the correct order, but couldnt get this strategy to work. Will revisit later if we still depend on the ordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some new unit tests to Annotation_Update. Putting these on hold for now and instead working on the Annotation_Update refactor, so figure we can just merge the new tests in.
Ignore the huge diff for
default/tests/shared/test_annotation.py, I just re-ordered the tests so that similar tests were grouped together