fix(json-render-ui): restore shadow-root theming and scrollbars - #278
Merged
antfu merged 1 commit intoAug 21, 2026
Merged
Conversation
|
@dvcolomban is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
Restores correct theming behavior for the @devframes/json-render-ui dock renderer when mounted inside a real shadow root (matching Wind3 descendant-selector semantics), while also improving scrollbar styling and the shared shadow-CSS build pipeline.
Changes:
- Move
.dark/.light+color-schemeonto adisplay: contentsancestor so Wind3 dark-variant selectors apply inside the renderer shadow root. - Add bundled scrollbar styling + stable scrollbar gutter for the renderer scroll root.
- Extend
design/build-shadow-css.tsto accept and merge multiple ordered hand-authored stylesheets, updating callers accordingly and adding a Storybook fixture that mounts the shipped dock renderer in a shadow root.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/json-render-ui/src/renderer-module/style.css | Adds stable scrollbar gutter for the dock renderer scroll root. |
| packages/json-render-ui/src/renderer-module/index.ts | Fixes shadow-root theme class placement and keeps renderer shell transparent while preserving color-scheme. |
| packages/json-render-ui/src/JsonRender.stories.ts | Adds a Storybook fixture that mounts the shipped dock renderer in a real shadow root. |
| packages/json-render-ui/scripts/build-css.ts | Bundles design-system scrollbar stylesheet + renderer-module styles into the generated shadow CSS. |
| packages/hub-ui/scripts/build-css.ts | Updates build script to the new userStylePaths option shape. |
| design/build-shadow-css.ts | Generalizes build pipeline to merge multiple ordered user stylesheets (post-transform). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dvcolomban
force-pushed
the
codex/fix-json-render-shadow-shell
branch
from
August 21, 2026 17:27
8032698 to
849ee57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before
After