Skip to content

Commit f4339bc

Browse files
antfubotantfubot
authored
feat(devframe): expose utils/get-port, drop plugin deps on get-port-please (#249)
1 parent 8f744b7 commit f4339bc

26 files changed

Lines changed: 50 additions & 48 deletions

File tree

‎packages/devframe/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
"./utils/colors": "./dist/utils/colors.mjs",
4949
"./utils/crypto-token": "./dist/utils/crypto-token.mjs",
5050
"./utils/events": "./dist/utils/events.mjs",
51+
"./utils/get-port": "./dist/utils/get-port.mjs",
5152
"./utils/hash": "./dist/utils/hash.mjs",
5253
"./utils/launch-editor": "./dist/utils/launch-editor.mjs",
5354
"./utils/nanoid": "./dist/utils/nanoid.mjs",

‎packages/devframe/src/utils/get-port.ts‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
// Re-exported so plugins and other `devframe/*` consumers can resolve a
2+
// free port without taking their own dependency on `get-port-please` — it
3+
// travels as a `devframe` devDependency instead, bundled into this
4+
// package's node build (see `tsdown.config.ts`'s `deps.onlyBundle`).
5+
export { getPort } from 'get-port-please'
6+
export type { GetPortInput, GetPortOptions } from 'get-port-please'

‎packages/devframe/tsdown.config.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ const serverEntries = {
102102
'node/auth': 'src/node/auth/index.ts',
103103
'node/hub-internals': 'src/node/hub-internals/index.ts',
104104
'internal/index': 'src/internal/index.ts',
105+
'utils/get-port': 'src/utils/get-port.ts',
105106
'utils/launch-editor': 'src/utils/launch-editor.ts',
106107
'utils/nostics': 'src/utils/nostics.ts',
107108
'utils/open': 'src/utils/open.ts',

‎plugins/a11y/demo/server.mjs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ import { createServer } from 'node:http'
2323
import process from 'node:process'
2424
import { fileURLToPath } from 'node:url'
2525
import { initDevframe } from 'devframe/initiate'
26+
import { getPort } from 'devframe/utils/get-port'
2627
import { mountStaticHandler } from 'devframe/utils/serve-static'
27-
import { getPort } from 'get-port-please'
2828
import { H3, toNodeHandler } from 'h3'
2929
import { resolve } from 'pathe'
3030
import createA11yDevframe from '../src/index.ts'

‎plugins/a11y/package.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@
7373
"axe-core": "catalog:frontend",
7474
"colorjs.io": "catalog:frontend",
7575
"devframe": "workspace:*",
76-
"get-port-please": "catalog:deps",
7776
"h3": "catalog:deps",
7877
"solid-js": "catalog:frontend",
7978
"storybook": "catalog:storybook",

‎plugins/a11y/tests/_utils.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ import process from 'node:process'
66
import { DEVFRAME_CONNECTION_META_FILENAME } from 'devframe/constants'
77
import { createH3DevframeHost } from 'devframe/internal'
88
import { createHostContext } from 'devframe/node'
9+
import { getPort } from 'devframe/utils/get-port'
910
import { resolveStaticAssetsSource } from 'devframe/utils/remote-assets'
1011
import { mountStaticHandler } from 'devframe/utils/serve-static'
11-
import { getPort } from 'get-port-please'
1212
import { H3 } from 'h3'
1313
import { resolve } from 'pathe'
1414
import { serveTestContext } from '../../../tests/helpers/serve-test-context'

‎plugins/assets/package.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@
8181
"colorjs.io": "catalog:frontend",
8282
"devframe": "workspace:*",
8383
"floating-vue": "catalog:frontend",
84-
"get-port-please": "catalog:deps",
8584
"h3": "catalog:deps",
8685
"reka-ui": "catalog:frontend",
8786
"storybook": "catalog:storybook",

‎plugins/assets/test/_utils.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ import { createH3DevframeHost } from 'devframe/internal'
1010
import { createHostContext } from 'devframe/node'
1111
import { createRpcClient } from 'devframe/rpc/client'
1212
import { createWsRpcChannel } from 'devframe/rpc/transports/ws-client'
13+
import { getPort } from 'devframe/utils/get-port'
1314
import { mountStaticHandler } from 'devframe/utils/serve-static'
14-
import { getPort } from 'get-port-please'
1515
import { H3 } from 'h3'
1616
import { serveTestContext } from '../../../tests/helpers/serve-test-context'
1717
import { createAssetsDevframe } from '../src/index'

‎plugins/code-server/package.json‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,7 @@
6464
},
6565
"dependencies": {
6666
"@devframes/vite": "workspace:*",
67-
"cac": "catalog:deps",
68-
"get-port-please": "catalog:deps"
67+
"cac": "catalog:deps"
6968
},
7069
"devDependencies": {
7170
"@antfu/design": "catalog:frontend",

‎plugins/code-server/src/node/supervisor.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import { randomBytes } from 'node:crypto'
2121
import { request as httpRequest } from 'node:http'
2222
import { hostname } from 'node:os'
2323
import process from 'node:process'
24-
import { getPort } from 'get-port-please'
24+
import { getPort } from 'devframe/utils/get-port'
2525
import {
2626
DEFAULT_CODE_SERVER_PORT,
2727
DEFAULT_START_TIMEOUT,

0 commit comments

Comments
 (0)