Skip to content

[Devtools] Update Readme Links#43

Merged
Jdubrick merged 2 commits into
devfile-samples:v2.0.0from
Jdubrick:v2.0.0
Mar 1, 2024
Merged

[Devtools] Update Readme Links#43
Jdubrick merged 2 commits into
devfile-samples:v2.0.0from
Jdubrick:v2.0.0

Conversation

@Jdubrick

Copy link
Copy Markdown
Contributor

This PR updates the readme to contain the correct references to pieces of code in various devfile.yaml files. Additionally, v2.0.0 uses a parent devfile, the documentation was also updated to reference this parent when necessary.

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

@michael-valdron michael-valdron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! A few revisions I would suggest.

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

@michael-valdron michael-valdron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Jdubrick Jdubrick merged commit 22342f0 into devfile-samples:v2.0.0 Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants