Skip to content

Create springboot sample 2.0.0 version#37

Merged
thepetk merged 3 commits into
devfile-samples:v2.0.0from
thepetk:update_devfile
Nov 28, 2023
Merged

Create springboot sample 2.0.0 version#37
thepetk merged 3 commits into
devfile-samples:v2.0.0from
thepetk:update_devfile

Conversation

@thepetk

@thepetk thepetk commented Nov 7, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?:

This PR creates a new version of java-springboot-basic sample. The new version uses the 2.1.0 version of python stack instead of the default one 1.2.0.

Which issue(s) this PR fixes:

fixes devfile/api#1360

Signed-off-by: thepetk <thepetk@gmail.com>
@maysunfaisal

Copy link
Copy Markdown
Contributor

@thepetk didnt we discuss that parent might not be supported in ODC, 🤔

Signed-off-by: thepetk <thepetk@gmail.com>
@thepetk thepetk requested a review from maysunfaisal November 21, 2023 22:26
@thepetk

thepetk commented Nov 21, 2023

Copy link
Copy Markdown
Contributor Author

@thepetk didnt we discuss that parent might not be supported in ODC, 🤔

@maysunfaisal as discussed together we will keep the parent overrides. I've also updated the port to 8080 instead of 8081

@thepetk thepetk merged commit beac7d1 into devfile-samples:v2.0.0 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Devfile Samples to reference v2.2.0 Parent stacks

2 participants