Merged
Conversation
📝 WalkthroughWalkthroughThe change updates the package’s published name from "python-lsp-server" to "deepnote-python-lsp-server". This is applied in two places: pyproject.toml ([project].name) and setup.py (setup(name=...)). No source code, configuration beyond naming, or runtime behavior is modified. Distribution metadata and install target are affected. Pre-merge checks✅ Passed checks (3 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
pyproject.toml(1 hunks)setup.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: Mac Py3.9
- GitHub Check: Mac Py3.8
- GitHub Check: Mac Py3.10
- GitHub Check: Win Py3.10
- GitHub Check: Win Py3.8
- GitHub Check: Win Py3.9
- GitHub Check: Linux Py3.10
- GitHub Check: Linux Py3.9
- GitHub Check: Linux Py3.8
🔇 Additional comments (1)
setup.py (1)
10-10: LGTM! Consistent with pyproject.toml.Name change matches pyproject.toml. Comment clarifies purpose.
m1so
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit