Skip to content

fixes #987 fallback to localStorage.DEBUG if debug is not defined#988

Merged
Qix- merged 1 commit intodebug-js:masterfrom
lzilioli:master
Mar 23, 2025
Merged

fixes #987 fallback to localStorage.DEBUG if debug is not defined#988
Qix- merged 1 commit intodebug-js:masterfrom
lzilioli:master

Conversation

@lzilioli
Copy link
Contributor

@lzilioli lzilioli commented Jan 15, 2025 •
edited
Loading

Tweak to address #987. From that issue:

I often get tripped up by the fact that I need to set localStorage.debug but in the node environment its DEBUG (lower versus upper case). It would be a nice enhancement if the debug package in the browser checked localStorage.debug || localStorage.DEBUG, if it did, it would save me an (embarrassing) amount of time.

@lzilioli
Copy link
Contributor Author

lzilioli commented Mar 23, 2025

@Qix- i saw you close/merge some other PRs in this repo, so wanted to ping you on this one to see if you'd be willing to merge it in. Thanks!

@Qix-
Copy link
Member

Qix- commented Mar 23, 2025

Honestly should have been DEBUG from the start but alas no changing that now.
Yea this looks good to me, sorry it fell through the cracks. I'm quite busy this week so if I don't get a release out in the next week or so you can harass me again to get one out.

Thanks for the PR. :)

@Qix- Qix- merged commit bf2f574 into debug-js:master Mar 23, 2025
Blankll added a commit to geek-fun/dockit that referenced this pull request Jun 14, 2025
@Blankll @snyk-bot
[Snyk] Upgrade debug from 4.4.0 to 4.4.1 (#216)
0db697c 
![snyk-top-banner](https://res.cloudinary.com/snyk/image/upload/r-d/scm-platform/snyk-pull-requests/pr-banner-default.svg)


<h3>Snyk has created this PR to upgrade debug from 4.4.0 to 4.4.1.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.

<hr/>


- The recommended version is **1 version** ahead of your current
version.

- The recommended version was released **a month ago**.



<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>debug</b></summary>
    <ul>
      <li>
<b>4.4.1</b> - <a
href="https://redirect.github.com/debug-js/debug/releases/tag/4.4.1">2025-05-13</a></br><h2>What's
Changed</h2>
<ul>
<li>fix(Issue-996): replace whitespaces in namespaces string with commas
globally by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/pdahal-cx/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/pdahal-cx">@ pdahal-cx</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2938748601" data-permission-text="Title is private"
data-url="debug-js/debug#997"
data-hovercard-type="pull_request"
data-hovercard-url="/debug-js/debug/pull/997/hovercard"
href="https://redirect.github.com/debug-js/debug/pull/997">#997</a></li>
<li>fixes <a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2788605483" data-permission-text="Title is private"
data-url="debug-js/debug#987"
data-hovercard-type="issue"
data-hovercard-url="/debug-js/debug/issues/987/hovercard"
href="https://redirect.github.com/debug-js/debug/issues/987">#987</a>
fallback to localStorage.DEBUG if debug is not defined by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/lzilioli/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/lzilioli">@ lzilioli</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2788615273" data-permission-text="Title is private"
data-url="debug-js/debug#988"
data-hovercard-type="pull_request"
data-hovercard-url="/debug-js/debug/pull/988/hovercard"
href="https://redirect.github.com/debug-js/debug/pull/988">#988</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/pdahal-cx/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/pdahal-cx">@ pdahal-cx</a> made their
first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2938748601"
data-permission-text="Title is private"
data-url="debug-js/debug#997"
data-hovercard-type="pull_request"
data-hovercard-url="/debug-js/debug/pull/997/hovercard"
href="https://redirect.github.com/debug-js/debug/pull/997">#997</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/lzilioli/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/lzilioli">@ lzilioli</a> made their
first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2788615273"
data-permission-text="Title is private"
data-url="debug-js/debug#988"
data-hovercard-type="pull_request"
data-hovercard-url="/debug-js/debug/pull/988/hovercard"
href="https://redirect.github.com/debug-js/debug/pull/988">#988</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a class="commit-link"
href="https://redirect.github.com/debug-js/debug/compare/4.4.0...4.4.1"><tt>4.4.0...4.4.1</tt></a></p>
      </li>
      <li>
<b>4.4.0</b> - <a
href="https://redirect.github.com/debug-js/debug/releases/tag/4.4.0">2024-12-06</a></br><p>Fixes
(hopefully) the inefficient regex warnings in
<code>.enable()</code>.</p>
<p>Minor version as this is invariably going to break certain users who
misuse the <code>.enable()</code> API and expected it to work with
regexes, which was never supported nor documented. That's on you, sorry
- that functionality won't be added back.</p>
<p><strong>Full Changelog</strong>: <a class="commit-link"
href="https://redirect.github.com/debug-js/debug/compare/4.3.7...4.4.0"><tt>4.3.7...4.4.0</tt></a></p>
      </li>
    </ul>
from <a href="https://redirect.github.com/debug-js/debug/releases">debug
GitHub release notes</a>
  </details>
</details>

---

> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with
your project.
> - This PR was automatically created by Snyk using the credentials of a
real user.

---

**Note:** _You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs._

**For more information:** <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJmZjJiOTA5NS1lM2U0LTQ2MjUtYmY5ZC1kYzAzMzkwMzdiYzciLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImZmMmI5MDk1LWUzZTQtNDYyNS1iZjlkLWRjMDMzOTAzN2JjNyJ9fQ=="
width="0" height="0"/>

> - 🧐 [View latest project
report](https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 📜 [Customise PR
templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates?utm_source=&utm_content=fix-pr-template)
> - 🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24/settings/integration?pkg&#x3D;debug&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

[//]: #
'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"debug","from":"4.4.0","to":"4.4.1"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"ff2b9095-e3e4-4625-bf9d-dc0339037bc7","prPublicId":"ff2b9095-e3e4-4625-bf9d-dc0339037bc7","packageManager":"npm","priorityScoreList":[],"projectPublicId":"d19c39b4-9b25-4232-b09a-2d71e94c8a24","projectUrl":"https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2025-05-13T20:56:36.431Z"},"vulns":[]}'

Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Blankll added a commit to geek-fun/dockit that referenced this pull request Dec 26, 2025
@Blankll @snyk-bot
[Snyk] Upgrade debug from 4.4.1 to 4.4.3 (#248)
d516a21 
![snyk-top-banner](https://res.cloudinary.com/snyk/image/upload/r-d/scm-platform/snyk-pull-requests/pr-banner-default.svg)


<h3>Snyk has created this PR to upgrade debug from 4.4.1 to 4.4.3.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.

<hr/>


- The recommended version is **1 version** ahead of your current
version.

- The recommended version was released **a month ago**.




<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>debug</b></summary>
    <ul>
      <li>
<b>4.4.3</b> - <a
href="https://redirect.github.com/debug-js/debug/releases/tag/4.4.3">2025-09-13</a></br><p>Functionally
identical release to <code>4.4.1</code>.</p>
<p>Version <code>4.4.2</code> is <strong>compromised</strong>. Please
see <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="3394266240" data-permission-text="Title is private"
data-url="debug-js/debug#1005"
data-hovercard-type="issue"
data-hovercard-url="/debug-js/debug/issues/1005/hovercard"
href="https://redirect.github.com/debug-js/debug/issues/1005">#1005</a>.</p>
      </li>
      <li>
<b>4.4.1</b> - <a
href="https://redirect.github.com/debug-js/debug/releases/tag/4.4.1">2025-05-13</a></br><h2>What's
Changed</h2>
<ul>
<li>fix(Issue-996): replace whitespaces in namespaces string with commas
globally by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/pdahal-cx/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/pdahal-cx">@ pdahal-cx</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2938748601" data-permission-text="Title is private"
data-url="debug-js/debug#997"
data-hovercard-type="pull_request"
data-hovercard-url="/debug-js/debug/pull/997/hovercard"
href="https://redirect.github.com/debug-js/debug/pull/997">#997</a></li>
<li>fixes <a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2788605483" data-permission-text="Title is private"
data-url="debug-js/debug#987"
data-hovercard-type="issue"
data-hovercard-url="/debug-js/debug/issues/987/hovercard"
href="https://redirect.github.com/debug-js/debug/issues/987">#987</a>
fallback to localStorage.DEBUG if debug is not defined by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/lzilioli/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/lzilioli">@ lzilioli</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2788615273" data-permission-text="Title is private"
data-url="debug-js/debug#988"
data-hovercard-type="pull_request"
data-hovercard-url="/debug-js/debug/pull/988/hovercard"
href="https://redirect.github.com/debug-js/debug/pull/988">#988</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/pdahal-cx/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/pdahal-cx">@ pdahal-cx</a> made their
first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2938748601"
data-permission-text="Title is private"
data-url="debug-js/debug#997"
data-hovercard-type="pull_request"
data-hovercard-url="/debug-js/debug/pull/997/hovercard"
href="https://redirect.github.com/debug-js/debug/pull/997">#997</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/lzilioli/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/lzilioli">@ lzilioli</a> made their
first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2788615273"
data-permission-text="Title is private"
data-url="debug-js/debug#988"
data-hovercard-type="pull_request"
data-hovercard-url="/debug-js/debug/pull/988/hovercard"
href="https://redirect.github.com/debug-js/debug/pull/988">#988</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a class="commit-link"
href="https://redirect.github.com/debug-js/debug/compare/4.4.0...4.4.1"><tt>4.4.0...4.4.1</tt></a></p>
      </li>
    </ul>
from <a href="https://redirect.github.com/debug-js/debug/releases">debug
GitHub release notes</a>
  </details>
</details>

---

> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with
your project.
> - This PR was automatically created by Snyk using the credentials of a
real user.

---

**Note:** _You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs._

**For more information:** <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJkM2NhNWZkYy0wNDI2LTRiN2QtODgwYS0zNGIzMmI2MWZlY2UiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImQzY2E1ZmRjLTA0MjYtNGI3ZC04ODBhLTM0YjMyYjYxZmVjZSJ9fQ=="
width="0" height="0"/>

> - 🧐 [View latest project
report](https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 📜 [Customise PR
templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates?utm_source=&utm_content=fix-pr-template)
> - 🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24/settings/integration?pkg&#x3D;debug&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

[//]: #
'snyk:metadata:{"breakingChangeRiskLevel":null,"FF_showPullRequestBreakingChanges":null,"FF_showPullRequestBreakingChangesWebSearch":null,"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"debug","from":"4.4.1","to":"4.4.3"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"d3ca5fdc-0426-4b7d-880a-34b32b61fece","prPublicId":"d3ca5fdc-0426-4b7d-880a-34b32b61fece","packageManager":"npm","priorityScoreList":[],"projectPublicId":"d19c39b4-9b25-4232-b09a-2d71e94c8a24","projectUrl":"https://app.snyk.io/org/blankll/project/d19c39b4-9b25-4232-b09a-2d71e94c8a24?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2025-09-13T17:25:19.732Z"},"vulns":[]}'

Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lzilioli @Qix-

Comments