Update greaterThanOrEqual to ensure argument 'other' is a Long#18
Closed
blake-nicholson wants to merge 2 commits into
Closed
Update greaterThanOrEqual to ensure argument 'other' is a Long#18blake-nicholson wants to merge 2 commits into
blake-nicholson wants to merge 2 commits into
Conversation
added 2 commits
May 11, 2015 14:53
Previously, passing in a non-Long would cause an error.
Now greaterThanOrEqual ensures that argument 'other' is a Long before passing it to compare.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified greaterThanOrEqual to follow the same pattern as lessThan, lessThanOrEqual, greaterThan, etc. so that the argument to the function is converted to a Long if it is not one already.