Skip to content

Minor adjustments for release#889

Merged
dimitri-yatsenko merged 24 commits into
datajoint:release013from
guzman-raphael:adjustments
Mar 24, 2021
Merged

Minor adjustments for release#889
dimitri-yatsenko merged 24 commits into
datajoint:release013from
guzman-raphael:adjustments

Conversation

@guzman-raphael

@guzman-raphael guzman-raphael commented Mar 23, 2021

Copy link
Copy Markdown
Collaborator

This PR addresses the following items to prepare for release:

  • Adds deprecation warning on _update
  • Removes use of from None when raised instances of DataJointError
  • Adds to query expression overloaded operators docstrings the operator reference
  • Adds purge_query_cache method
  • Adds test for query caching
  • Adds basic tests for permissive restrictions and joins
  • Moves transpiler_specs.md documentation to our proper documentation
  • Integrates QueryCache and Update1 docs into proper documentation
  • Adjusts version properly
  • Addresses merge conflict issue

@guzman-raphael guzman-raphael marked this pull request as ready for review March 24, 2021 00:43
Comment thread datajoint/expression.py
def __contains__(self, item):
"""
returns True if item is found in the .
returns True if a restriction results with any records e.g. restriction in q1.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
returns True if a restriction results with any records e.g. restriction in q1.
returns True if the restriction in item matches any entries in self

Comment thread datajoint/expression.py
returns the next record on an iterator-compatible QueryExpression object
e.g. next(q1).

:param self: fetch1 record

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here self is a QueryExpression that has been primed with iter to yield dicts containing the primary key values.

Comment thread datajoint/expression.py
"""
returns the string representation of a QueryExpression object e.g. str(q1).

:param self: String version of query result

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here self is a QueryExpression.

@dimitri-yatsenko dimitri-yatsenko merged commit 6f9a022 into datajoint:release013 Mar 24, 2021
@guzman-raphael guzman-raphael linked an issue Mar 24, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add new update documentation

2 participants