Fix S3 remove_object and add external location checks#781
Merged
Conversation
dimitri-yatsenko
previously requested changes
May 11, 2020
eywalker
approved these changes
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s3remove object caller (Fix Filepath: delete_external_files=True does not remove from S3 external store #686)s3bucket andfilestorage location existence checks (Fix DataJoint should not create S3 buckets and storage root paths. #748)minioon port 80Note:
filestore directory check here is a temporary fix until external storage can be properly redesigned to be compatible withpluginframework.