add method update1 to dj.Table#763
Merged
Merged
Conversation
guzman-raphael
requested changes
Apr 20, 2020
guzman-raphael
left a comment
Collaborator
There was a problem hiding this comment.
Awesome! Can you add a filepath test? Say if the user want to modify a tracked file? Also, since this is not slated for the next 0.12.6 release, can you target a feature branch?
Member
Author
|
@guzman-raphael Your review comment has been addressed. |
guzman-raphael
approved these changes
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
Table.update1that works similarly toinsert1, updating specified secondary attributes.