Fix Coveralls, Centralize Reverse Proxy (NGINX), and add Flake8 Linter#757
Merged
Conversation
dimitri-yatsenko
approved these changes
Apr 13, 2020
dimitri-yatsenko
approved these changes
Apr 14, 2020
Member
|
Would you resolve the conflict and then we will merge. This looks great! |
eywalker
approved these changes
Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with
coverallsand moves the logic for thefakeservices.datajoint.ioreverse proxy to centralize into a dedicate image. This is necessary for reuse withdatajoint-matlab. Also, newflake8python linter was added for syntax and style checks along with appropriate code base update.Notable source updates:
Uimport fromautopopulate.pyheading.pyi.e.\signedcontents_hash_functionfrommigrate.pyAlso, reduced testing matrix to test
MySQL 5.7on all supportedpythonreleases and remainingMySQLversions only on latestpythonrelease.Fix #756
Fix #758
Fix #759