Skip to content

Handle invocation from newer Danger JS versions #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orta merged 1 commit into from
Sep 6, 2023
Merged

Handle invocation from newer Danger JS versions #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions danger_python/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ def cli() -> None:
@cli.command()
def run() -> None:
"""Runs dangerfile.py as a danger process"""
runner()


@danger_command(cli, "runner")
def runner(arguments: List[str]) -> None:
"""Runs dangerfile.py as a danger process, ignoring unknown options"""
with open("dangerfile.py", "r") as dangerfile:
try:
execute_dangerfile(dangerfile.read())
Expand Down
20 changes: 12 additions & 8 deletions tests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,29 +69,31 @@ def test_ci_command_invokes_danger_js_passing_arguments():
assert result.output == "The output!\n"


@pytest.mark.parametrize("command", ["run", "runner"])
@pytest.mark.parametrize(
"dangerfile", ['print("Hello world")\n' 'print("Goodbye world")']
)
@pytest.mark.usefixtures("danger")
def test_run_command_invokes_dangerfile():
def test_run_command_invokes_dangerfile(command):
"""
Test that run command invokes dangerfile.py contents.
"""
runner = CliRunner()
result = runner.invoke(cli, ["run"])
result = runner.invoke(cli, [command])

assert result.exit_code == 0
assert result.output.startswith("Hello world\nGoodbye world\n")


@pytest.mark.parametrize("command", ["run", "runner"])
@pytest.mark.parametrize("dangerfile", ["This is not a valid syntax of Python"])
@pytest.mark.usefixtures("danger")
def test_run_command_shows_traceback_when_dangerfile_fails():
def test_run_command_shows_traceback_when_dangerfile_fails(command):
"""
Test that run command shows traceback when dangerfile.py fails.
"""
runner = CliRunner(mix_stderr=False)
result = runner.invoke(cli, ["run"])
result = runner.invoke(cli, [command])

expected_error = (
"There was an error when executing dangerfile.py:\n"
Expand All @@ -116,21 +118,23 @@ def test_default_command_invokes_dangerfile():
assert result.output.startswith("Default command\n")


@pytest.mark.parametrize("command", ["run", "runner"])
@pytest.mark.parametrize("modified_files", [["a.py", "b.py"]])
@pytest.mark.parametrize("dangerfile", ["print(danger.git.modified_files)"])
@pytest.mark.usefixtures("danger")
def test_executing_dangerfile_passes_danger_instance_to_the_script():
def test_executing_dangerfile_passes_danger_instance_to_the_script(command):
"""
Test that executing run command passes danger instance with parsed input
to the Dangerfile locals.
"""
runner = CliRunner()
result = runner.invoke(cli, ["run"])
result = runner.invoke(cli, [command])

assert result.exit_code == 0
assert result.output.startswith("['a.py', 'b.py']\n")


@pytest.mark.parametrize("command", ["run", "runner"])
@pytest.mark.parametrize(
"dangerfile",
[
Expand All @@ -141,12 +145,12 @@ def test_executing_dangerfile_passes_danger_instance_to_the_script():
],
)
@pytest.mark.usefixtures("danger")
def test_executing_dangerfile_prints_results_to_stdout():
def test_executing_dangerfile_prints_results_to_stdout(command):
"""
Test that executing run command reports results back to output.
"""
runner = CliRunner()
result = runner.invoke(cli, ["run"])
result = runner.invoke(cli, [command])

expected_json = {
"fails": [{"message": "You are going to fail"}],
Expand Down