Repository navigation
unit1399: check microsecond precision across redirects - #23258
Open
renanmpimentel wants to merge 2 commits into
Open
renanmpimentel wants to merge 2 commits into
renanmpimentel wants to merge 2 commits into
Conversation
Compare timer totals in microseconds instead of truncating to seconds. Use fractional request durations to detect lost sub-second timing while preserving the repeated STARTTRANSFER checks. AI-assisted audit using Supertest.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The deterministic assertions correctly detect fractional timing loss without altering production behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Strengthens redirect timing tests by asserting exact microsecond totals instead of truncated seconds.
Changes:
- Tests 2.25-second and 1.5-second redirect timings.
- Verifies the accumulated 3,750,000-microsecond total.
- Preserves repeated
STARTTRANSFERchecks.
| File | Description |
|---|---|
tests/unit/unit1399.c |
Adds microsecond-precision redirect timer assertions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The redirect timer assertions in unit1399 divide microseconds by one
million before comparing, so they accept lost fractional timing.
Compare the raw microsecond totals and use 2.25s and 1.5s requests.
The expected accumulated value is 3,750,000 microseconds. The
existing repeated STARTTRANSFER checks remain in place.
Verified: a whole-second truncation regression passes all 79 original
unit tests and fails unit1399 with this change; restoring production
passes. Full native suite: 1,895 passed,233 skipped. HTTP suite:
710 passed,134 skipped. checksrc and the strict compiler build pass.
AI-assisted audit using Supertest.