csskit_ast: Use ErasedNode in selector matching, add NodeKey for identity - #1443
Merged
keithamus merged 1 commit intoAug 23, 2026
Conversation
keithamus
enabled auto-merge (squash)
August 23, 2026 09:01
…tity A node ID identifies its syntax kind but not a specific entry in a parsed tree. Dynamic consumers (such as selector matcher) therefore cannot map selector matches back to the concrete nodes they represent. This change implements a NodeKey type which carries both the NodeId and the position in the tree, so that selector matching can make use of the ErasedNode object safe traits.
keithamus
force-pushed
the
csskit-ast-use-erasednode-in-selector-matching-add-nodekey-for-identity
branch
from
August 23, 2026 09:16
7748610 to
39ce13f
Compare
✅ CI passed
|
keithamus
deleted the
csskit-ast-use-erasednode-in-selector-matching-add-nodekey-for-identity
branch
August 23, 2026 09:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A node ID identifies its syntax kind but not a specific entry in a parsed tree.
Dynamic consumers (such as selector matcher) therefore cannot map selector
matches back to the concrete nodes they represent.
This change implements a NodeKey type which carries both the NodeId and the
position in the tree, so that selector matching can make use of the ErasedNode
object safe traits.