css_ast: Clean up & improve NodeWithMetadata derives, add value_kinds - #1422
Merged
keithamus merged 1 commit intoAug 20, 2026
Merged
Conversation
Lots of nodes didn't implement NodeWithMetadata, which this fixes, it also tidies up some other problems, such as eager fetching of metadata, and adds new metadata around value kinds.
keithamus
enabled auto-merge (squash)
August 20, 2026 18:47
✅ CI passed
|
keithamus
deleted the
css-ast-clean-up-improve-nodewithmetadata-derives-add-value-kinds
branch
August 20, 2026 18:58
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 22, 2026
## [0.0.30] - 2026-08-22 ### Css_ast - css_ast: Allow symbolic-counter-style in content syntax (#1419) ([#1419](#1419)) - css_ast: Boxup rare nodes to reduce allocation size (#1421) ([#1421](#1421)) - css_ast: Clean up & improve NodeWithMetadata derives, add value_kinds (#1422) ([#1422](#1422)) - csskit_transform: implement ReduceCharsetRule (#1427) ([#1427](#1427)) - css_ast: Add missing webkit pseudo elements (#1428) ([#1428](#1428)) - css_ast: Implement InitialLetterAlignStyleValue (#1429) ([#1429](#1429)) ### Css_lexer - css_lexer/css_parse: Ensure parsed whitespace survives minification (#1420) ([#1420](#1420)) ### Csskit - chore(deps): update dependencies (patch) (#1407) ([#1407](#1407)) ### Csskit_transform - coverage: update css-minify-tests (#1423) ([#1423](#1423)) - csskit_transform: skip subtrees which don't match metadata (#1424) ([#1424](#1424)) ### Csskit_vscode - chore(deps): update dependency mocha to v11.8.0 (#1410) ([#1410](#1410)) - chore(deps): update dependency oxlint to v1.76.0 (#1411) ([#1411](#1411)) - chore(deps): update dependency oxlint to v1.78.0 (#1413) ([#1413](#1413)) ### Derive_atom_set - derive_atom_set: Don't case fold on punctuation. (#1426) ([#1426](#1426)) [forcebuild]
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 22, 2026
## [0.0.30] - 2026-08-22 ### Css_ast - css_ast: Allow symbolic-counter-style in content syntax (#1419) ([#1419](#1419)) - css_ast: Boxup rare nodes to reduce allocation size (#1421) ([#1421](#1421)) - css_ast: Clean up & improve NodeWithMetadata derives, add value_kinds (#1422) ([#1422](#1422)) - csskit_transform: implement ReduceCharsetRule (#1427) ([#1427](#1427)) - css_ast: Add missing webkit pseudo elements (#1428) ([#1428](#1428)) - css_ast: Implement InitialLetterAlignStyleValue (#1429) ([#1429](#1429)) ### Css_lexer - css_lexer/css_parse: Ensure parsed whitespace survives minification (#1420) ([#1420](#1420)) ### Csskit - chore(deps): update dependencies (patch) (#1407) ([#1407](#1407)) ### Csskit_transform - coverage: update css-minify-tests (#1423) ([#1423](#1423)) - csskit_transform: skip subtrees which don't match metadata (#1424) ([#1424](#1424)) ### Csskit_vscode - chore(deps): update dependency mocha to v11.8.0 (#1410) ([#1410](#1410)) - chore(deps): update dependency oxlint to v1.76.0 (#1411) ([#1411](#1411)) - chore(deps): update dependency oxlint to v1.78.0 (#1413) ([#1413](#1413)) ### Derive_atom_set - derive_atom_set: Don't case fold on punctuation. (#1426) ([#1426](#1426))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of nodes didn't implement NodeWithMetadata, which this fixes, it
also tidies up some other problems, such as eager fetching of metadata,
and adds new metadata around value kinds.