Removing Visual Studio 2013 warnings#512
Closed
rguiotti wants to merge 3 commits into
Closed
Conversation
1>..\externals\tinyxml\tinyxml2.cpp(674): warning C4127: conditional expression is constant 1>..\externals\tinyxml\tinyxml2.cpp(708): warning C4127: conditional expression is constant 1>..\externals\tinyxml\tinyxml2.cpp(743): warning C4127: conditional expression is constant 1>..\externals\tinyxml\tinyxml2.cpp(750): warning C4127: conditional expression is constant
1>tokenize.cpp(3218): warning C4244: '=' : conversion from 'MathLib::bigint' to 'size_t', possible loss of data
Collaborator
|
Hi, the tinyxml changes should probably go here: https://github.com/leethomason/tinyxml2 (that's where we pull it from/from where we update it from time to time) |
Collaborator
|
btw.. thanks for your interest in Cppcheck. |
Collaborator
|
I will close this pull request now. I don't want to apply this. feel free to take care of my comment. or if you prefer to forget this and do something else in cppcheck feel free to do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, I am starting to look at cppcheck code and even though I´ve been using it for quite some time now, I am just trying to understand it better before I make real improvements to it.
Thank you for the great job you´ve been doing.