Do not wrap exceptions passed to boost::promise::set_exception in std… #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…::exception_ptr (fixes cpp-netlib#815) boost::promise only knows about boost::exception_ptr, and handles wrapping of concrete exception types into that itself. If passed std::exception_ptr, it will wrap it a second time and later throw the std::exception_ptr itself.
deanberris
approved these changes
Feb 14, 2018
Member
deanberris
left a comment
There was a problem hiding this comment.
LGTM
Thanks @HighCommander4!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…::exception_ptr (fixes #815)
boost::promise only knows about boost::exception_ptr, and handles
wrapping of concrete exception types into that itself. If passed
std::exception_ptr, it will wrap it a second time and later throw
the std::exception_ptr itself.