Skip to content

fix boost::network::uri::decode error - out of range because of '%' #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deanberris merged 7 commits into from
Sep 11, 2015
Merged

fix boost::network::uri::decode error - out of range because of '%' #553

deanberris merged 7 commits into from
Sep 11, 2015

Conversation

@cnagune
Copy link

@cnagune cnagune commented Aug 29, 2015

problem

  • if template type is "const char *" in boost::network::uri::detail::decode function,
    segmentation fault can occor.

cause

  • "const char *" type is not throw std::out_of_range

fix

  • check out of range

@deanberris
Copy link
Member

deanberris commented Sep 11, 2015

LGTM -- good catch! Thanks @cnagune!

deanberris added a commit that referenced this pull request Sep 11, 2015
@deanberris
Merge pull request #553 from cnagune/0.11-devel-fix-decode-percent
947cc7e 
fix boost::network::uri::decode error - out of range because of '%'
@deanberris deanberris merged commit 947cc7e into cpp-netlib:0.11-devel Sep 11, 2015
@susnux susnux mentioned this pull request Apr 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cnagune @deanberris