Skip to content

Conversation

@carun
Copy link

@carun carun commented Nov 28, 2014

Added example to store large streaming data directly to filesystem using async server. I have tried to modify the CMakeLists.txt so that this example will be built only if a C++11 compiler is found. But I have not got a chance to test it on a compiler that doesn't support C++11.

Please let me know if this looks fine.

@deanberris
Copy link
Member

There's a build breakage in this pull request -- can you address this and update the PR?

https://travis-ci.org/cpp-netlib/cpp-netlib/jobs/42373917#L2415

@deanberris
Copy link
Member

@carun -- I don't think I can merge this in this form. Please fix the errors pointed out if you still want this to make it into the 0.11.2 release (because I'm cutting the 0.11.1 release now).

@deanberris
Copy link
Member

@carun -- Any update on this?

@carun
Copy link
Author

carun commented Feb 6, 2015

@deanberris -- Hi Deam, I'm so sorry.I have not used git before. So I was struggling to take it to the C+11 branch, messed my repo twice (I use hg all the time). Please let me know how to proceed further. I don't have time to work on this right now. But if there is a way to take these changes to the right branch, I would appreciate your help.

@ghost
Copy link

ghost commented Feb 7, 2015

Have you tried following the steps outlined here: http://cpp-netlib.org/process.html#pull-requests http://cpp-netlib.org/process.html#pull-requests ?

On Feb 7, 2015, at 1:13 AM, Arun Chandrasekaran notifications@github.com wrote:

@deanberris https://github.com/deanberris -- Hi Deam, I'm so sorry.I have not used git before. So I was struggling to take it to the C+11 branch, messed my repo twice (I use hg all the time). Please let me know how to proceed further. I don't have time to work on this right now. But if there is a way to take these changes to the right branch, I would appreciate your help.


Reply to this email directly or view it on GitHub #468 (comment).

@deanberris
Copy link
Member

Closing for lack of response. If you still have time and still want to get this in, I'd love to review it again @carun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants