Expose Slider Cursor Position for Better Control#404
Open
raquezha wants to merge 1 commit into
Open
Conversation
Author
|
I don't know if this changes will be accepted. Anyway if anyone want this feature grab it here: implementation 'com.github.raquezha:slidetoact:0.12.0' |
cortinico
requested changes
Mar 17, 2025
Comment on lines
+181
to
+183
| fun getSliderCursorPosition(): Int { | ||
| return mPosition | ||
| } |
Owner
There was a problem hiding this comment.
I think we should instead rename mPosition to sliderPosition and make it public rather than creating a custom getter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
getSliderCursorPosition()method, allowing developers to retrieve the current position of the slider cursor in SlideToActView.Description
By exposing this value, developers gain more control over the slider’s state, enabling various use cases such as:
Changes:
Added fun getSliderCursorPosition(): Int to expose the slider’s current position.
Usage Example: