Skip to content
This repository was archived by the owner on Oct 24, 2022. It is now read-only.

Comments

create_gist()#1

Closed
akaihola wants to merge 32 commits intocopitux:1dfed8fea8fc1f7eebfac3f21d02099043f39f71from
akaihola:gists
Closed

create_gist()#1
akaihola wants to merge 32 commits intocopitux:1dfed8fea8fc1f7eebfac3f21d02099043f39f71from
akaihola:gists

Conversation

@akaihola
Copy link

@akaihola akaihola commented Nov 7, 2011

Hi,

I forked from the last commit in your develop branch which I could get working (i.e. get_me() worked) and added the create_gist() method.

-Antti

@copitux
Copy link
Owner

copitux commented Nov 8, 2011

Hi,

Maybe, Do you want to pull request into kennethreitz repository?, I'm confused because you said "from your last commit on develop branch" and kennethreitz haven't that branch.

If you wanted to do a pull request in my repo, the day you commited there was new changes so please update before do a pull request.

Also, I'm working intensive on new desig and I think that I'm beginning to have something clean. You could see it

Regards and thanks

@akaihola
Copy link
Author

akaihola commented Nov 9, 2011

I started with the goal of implementing the feature for creating a gist. I first tried kennethreitz's repo and figured out how to authenticate to GitHub with it (g=github3.basic_auth(user,pass);u=g.get_me()). I then searched all forks for any existing gist-related functionality to build on top of, and found the gists() method in your develop branch.

However, I couldn't figure out how to authenticate using the head of your develop branch, so I bisected until I found the last revision which still had the basic_auth() and get_me() methods (1dfed8f). I checked out that revision and built create_gist() on top of that.

Today I merged latest changes from your develop branch, but I still can't figure out how to authenticate to GitHub with it. Any advice?

@akaihola akaihola closed this Nov 9, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants