Update Serving API - from backend PR #6272#366
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the TypeScript Serving API definitions to reflect recent changes in the backend. It introduces new types and constants for account plan statuses, adds a version field for custom domains within project configurations, and expands traffic source options to include AI tools. These updates ensure the frontend and other consumers of the API types are synchronized with the latest backend data structures. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
There was a problem hiding this comment.
Code Review
This pull request updates the TypeScript serving API types, which appears to be an auto-generated file. The changes correctly reflect an update from the backend API. My review includes one comment regarding code duplication for the new 'ai_tool' traffic source, which could pose a maintenance risk. I've suggested a refactoring to centralize the type definition.
| * Traffic source | ||
| */ | ||
| source?: 'campaign' | 'search' | 'referral' | 'direct'; | ||
| source?: 'campaign' | 'search' | 'referral' | 'direct' | 'ai_tool'; |
There was a problem hiding this comment.
This PR adds the 'ai_tool' traffic source in two places: here in VisitorSegments and in the source type on line 2828. This duplication creates a maintenance risk, as future updates might miss one of the locations.
To centralize the definition, you should use a single named type. This would involve refactoring the existing source type (ideally renaming it to Source or TrafficSource to follow naming conventions) and then referencing it here.
Example of a better approach:
// Define the type once
export type TrafficSource = 'campaign' | 'search' | 'referral' | 'direct' | 'ai_tool';
// ... in VisitorSegments
source?: TrafficSource;Since this file is auto-generated, this refactoring might need to be done in the source OpenAPI specification or the generation tool.
Updating TS Serving API after the latest changes from backend repo,
PR #6272