Skip to content
This repository was archived by the owner on Dec 11, 2024. It is now read-only.

Initial fragment support#230

Merged
mauricefisher64 merged 2 commits intomainfrom
fragment_support
Aug 30, 2024
Merged

Initial fragment support#230
mauricefisher64 merged 2 commits intomainfrom
fragment_support

Conversation

@mauricefisher64
Copy link
Contributor

@mauricefisher64 mauricefisher64 commented Aug 30, 2024

Changes in this pull request

New commands to add and validate BMFF fragmented assets. Support for globing to enables processing of complete DASH hierarchies.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

gpeacock
gpeacock suggested changes Aug 30, 2024
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 19.10112% with 72 lines in your changes missing coverage. Please review.

Project coverage is 47.89%. Comparing base (17863bd) to head (7074054).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/main.rs 19.10% 72 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   48.68%   47.89%   -0.79%     
==========================================
  Files           4        4              
  Lines         684      666      -18     
==========================================
- Hits          333      319      -14     
+ Misses        351      347       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gpeacock
gpeacock approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move the sign_fragment and verify_fragment to a fragment.rs file, but since e need to restructure everything for subcommands anyway, no need to do that now.

@mauricefisher64 mauricefisher64 merged commit 733fc3e into main Aug 30, 2024
@mauricefisher64 mauricefisher64 deleted the fragment_support branch August 30, 2024 22:33
@Xueeeeeeee
Copy link

Xueeeeeeee commented Sep 19, 2024

Hello, I got an error message (Error: glob patterns only allowed when using "fragment" command) when adding a manifest to a JPG since upgrated to v 0.9.8. I had no problem with the v 0.9.7 and the same JPG. Could this be a regression in version 0.9.8? Thanks a lot. Regards,Xue

scouten-adobe pushed a commit to contentauth/c2pa-rs that referenced this pull request Dec 10, 2024
@mauricefisher64
Initial fragment support (contentauth/c2patool#230)
4de5f8f 
* Initial fragment support

* code review fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gpeacock gpeacock gpeacock approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

safe to test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mauricefisher64 @codecov-commenter @Xueeeeeeee @gpeacock